Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react-native-sqlite-2 #10409

Closed
1 task done
KshamaShrey opened this issue Aug 17, 2022 · 3 comments
Closed
1 task done

Support react-native-sqlite-2 #10409

KshamaShrey opened this issue Aug 17, 2022 · 3 comments
Assignees
Labels
enhancement Extensions Tracks issues against community modules and extensions
Milestone

Comments

@KshamaShrey
Copy link

KshamaShrey commented Aug 17, 2022

Module

react-native-sqlite-2

Module repo url

https://github.com/craftzdog/react-native-sqlite-2

Target Version

0.69

Existing issue url

craftzdog/react-native-sqlite-2#134

Existing windows implementation?

  • Legacy/C# implementation

Which app/customer is requesting this module?

We are trying to upgrade the react-native-windows application to the latest version.In our current react-native-windows version 0.59.0-rc.1,the above mentioned package works as expected.

In what scenarios will this module be used?

To use local database for desktop applications

Essential Features

No response

@KshamaShrey KshamaShrey added enhancement Extensions Tracks issues against community modules and extensions labels Aug 17, 2022
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Aug 17, 2022
@chrisglein
Copy link
Member

Based on the diredtory this one should have current Windows support: https://github.com/andpor/react-native-sqlite-storage
It sounds like sqlite-2 exists because of problems with PouchDB in sqlite-storage. Is that the situation you're in? (I'm not familiar with any of that - just reading off the project's readmes)

If there's an existing RNW version from pre 0.59, AND there's a reference implementation in sqlite-storage, this should be something you can take a crack at updating and submitting a PR to that repo. It'd be adapting from the WPF C# to UWP C++, but with examples I'd imagine a lot of that code ports over.

@chrisglein chrisglein added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Aug 18, 2022
@KshamaShrey
Copy link
Author

@chrisglein Thank you for the quick reply.We will try replacing the package with react-native-sqlite-storage and check the functionality.
Thank you.

@ghost ghost added Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Aug 19, 2022
@chrisglein chrisglein removed the Needs: Attention 👋 An issue that had been tagged "Needs: Author Feedback" has received activity (label applied by bot) label Aug 22, 2022
@chrisglein chrisglein added this to the Backlog milestone Aug 22, 2022
@chiaramooney
Copy link
Contributor

Not something we plan to address on the Paper renderer as we move towards Fabric. If you would like to see this module supported on Fabric, please file an issue on the react-native-sqlite2 repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Extensions Tracks issues against community modules and extensions
Projects
None yet
Development

No branches or pull requests

5 participants