Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS update problem #840

Closed
alexeyMohnatkin opened this issue May 16, 2017 · 13 comments
Closed

IOS update problem #840

alexeyMohnatkin opened this issue May 16, 2017 · 13 comments
Assignees
Labels

Comments

@alexeyMohnatkin
Copy link

I'm trying to update ios app (ad-hoc build), but I don't see any changes. code-push cli says that updates have been installed. No problems with android.

code-push release-react appname-ios ios -d Production -t 1.0.8

image

code-push 1.17.4-beta
rn 0.42.0
IOS 10.3.1

Should it work on ad-hoc?

@sergey-akhalkov
Copy link
Contributor

Hi @alexeyMohnatkin, thanks for reaching us. I believe that ad-hoc apps should work with CodePush as well as other app. As of now, it is hard to say what goes wrong without any logs or code samples. Please let me know if you have any questions.

@sergey-akhalkov
Copy link
Contributor

sergey-akhalkov commented May 17, 2017

Hi @pvsong, I've a CodePushified react-native app that has been built in release mode and installed on the iPhone. It works well for me without any exception. Also here is the customer that has CodePushified app and successfully distributes it via TestFlight - then the app successfully downloads and applies CodePush update.
To determine the root cause the issue you probably need to set up an exception reporter library and share collected logs with me, so I would able to analyze it and try to determine the cause of the issue.
As of now it is really hard to say what goes wrong without any logs or code samples.

@jbcullis
Copy link

I have it working on Android and iOS without exception, however there seems to be an issue that has only presented on iOS where the app thinks it has successfully updated even if the update process was int interrupted. Once that issue occurs, the only way to get those devices to get up to date is to roll a new version.

@alexeyMohnatkin
Copy link
Author

@sergey-akhalkov, what logs do you need?
Here's my entry file

...
import codePush from 'react-native-code-push';
...
class App extends Component {
	render() {
		return (
			<Provider store={store}>
				<RootContainer />
			</Provider>
		);
	}
}

export default codePush(App);

There's another strange thing: when I run Staging build it installs updates from Production deployment.
image

image

And I have right app keys in right places, I checked many times.

@sergey-akhalkov
Copy link
Contributor

sergey-akhalkov commented May 19, 2017

@alexeyMohnatkin, I've just tried to configure and install test app on device that uses Release and Staging schemes and it works well for me. I've just completed this steps, then I've changed Archive's Build Configuration value from default "Release" to "Staging":
image

So could you please confirm if you've changed Archive's default Build Configuration value?

@sergey-akhalkov
Copy link
Contributor

Hi @jbcullis, could you please create new issue and provide us more info, so we would able to investigate and fix it?

@sergey-akhalkov
Copy link
Contributor

@alexeyMohnatkin, @jbcullis, closing this for now, please feel free to reopen or create new issue so we would able to help you.

@dwilt
Copy link

dwilt commented Jun 6, 2017

We're running into this issue as well. I've made some changes which I can confirm were correctly uploaded:

image

And in the console it says it updated:

image

but I'm not seeing my changes show up in the app. You can see the matching version number(14). Here's my code:

export function restartApp() {
    codePush.restartApp();
}

export default async function () {
    if (codePushEnabled) {
        const successCode = await codePush.sync({
            deploymentKey: CODEPUSH_KEY,
            installMode: codePush.InstallMode.ON_NEXT_RESTART
        });

        if (successCode === codePush.SyncStatus.UPDATE_INSTALLED) {
            store.dispatch(showUpdateModal());
        }
    }
}

When the app starts, we are calling sync, then on complete, showing a modal to let the user know we want them to restart the app:

image

When they click "Ok, restart!" it does restart the app and after a restart I can see in the console is shows "Reporting CodePush update success (v14)" but my changes aren't there. Any ideas?

This used to be working flawlessly but it wasn't until lately things aren't working properly.

Versions:

"react-native": "0.41.2",
"react-native-code-push": "^1.17.3-beta",

@sergey-akhalkov
Copy link
Contributor

Hi @dwilt, I've tried to reproduce the issue but with now luck, so could you please create new issue and provide us as much info as possible?

@dwilt
Copy link

dwilt commented Jun 6, 2017

@sergey-akhalkov I figured it out. We had a conditional inside of our AppDelegate.m file pointing to the packager bundle and not CodePush:

#ifdef DEBUG
    jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index.ios" fallbackResource:nil];
#else
    jsCodeLocation = [CodePush bundleURL];
#endif

which I double checked because of this comment

@sergey-akhalkov
Copy link
Contributor

@dwilt, got it, we also have an iOS Plugin Configuration guide, so you could also verify if everything is set upped correct.
Thank you for your response and let me know if you have any questions or see any issues.

@salujaharkirat
Copy link

@sergey-akhalkov changing Release to Staging under archives messes up with the Pod Dependencies. Pods are installed in Staging folder instead of Release folder but the linking occurs to Release folder which throws error ld: framework not found for pod files.

@sergey-akhalkov
Copy link
Contributor

Hi @jinxac, got it, let's continue investigation in the issue you have created #893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants