Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Replace the exclusive term #508

Closed
kuzminrobin opened this issue Feb 9, 2021 · 0 comments · Fixed by #500
Closed

Replace the exclusive term #508

kuzminrobin opened this issue Feb 9, 2021 · 0 comments · Fixed by #500
Labels
maintenance Improve codebase quality needs triage An initial review by a maintainer is needed

Comments

@kuzminrobin
Copy link
Contributor

  1. In src/QirRuntime/test/QIR-static/qir-driver.cpp see comment for line 60 (bool dummy);).
  2. See also this.

1

In general, style guide is to avoid the term "dummy," as that can be an exclusive term; something like "placeholder" or even "_" is strongly preferred.
Our own style guide on this isn't public, unfortunately, but it's worth noting both that our code of conduct explicitly bans discriminatory language, and that the term "dummy" is widely considered to fall under that definition. In particular, both Google and Twitter's style guides exclude "dummy" explicitly.
To be clear, I don't object to the functionality of having a placeholder argument like this, but I would strongly suggest that name be replaced as soon as is reasonably possible.

2 "Ensure exclusive language is not used in codebase"

@kuzminrobin kuzminrobin added needs triage An initial review by a maintainer is needed maintenance Improve codebase quality labels Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Improve codebase quality needs triage An initial review by a maintainer is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant