Fixed a bug that leads to a false positive when a function is decorat… #9518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed and has no explicit return type annotation and the body references the decorated function in a loop. This addresses #9492.
|
Diff from mypy_primer, showing the effect of this PR on open source code: ibis (https://github.com/ibis-project/ibis)
- /tmp/mypy_primer/projects/ibis/ibis/expr/operations/core.py:126:35 - error: Argument of type "() -> Unknown" cannot be assigned to parameter "s" of type "Iterable[_S@union]" in function "union"
+ /tmp/mypy_primer/projects/ibis/ibis/expr/operations/core.py:126:35 - error: Argument of type "Attribute" cannot be assigned to parameter "s" of type "Iterable[_S@union]" in function "union"
- "function" is incompatible with protocol "Iterable[_S@union]"
+ "Attribute" is incompatible with protocol "Iterable[_S@union]"
asynq (https://github.com/quora/asynq)
- /tmp/mypy_primer/projects/asynq/asynq/tools.py:268:25 - error: Cannot access attribute "alazy_constant_refresh_time" for class "function"
- Attribute "alazy_constant_refresh_time" is unknown (reportFunctionMemberAccess)
- 167 errors, 9 warnings, 0 informations
+ 166 errors, 9 warnings, 0 informations
prefect (https://github.com/PrefectHQ/prefect)
- /tmp/mypy_primer/projects/prefect/src/prefect/utilities/dispatch.py:126:33 - error: Cannot assign to attribute "__init_subclass__" for class "Type[Unknown]*"
- Type "(cls: Unknown, **kwargs: Unknown) -> None" is not assignable to type "() -> None"
- Extra parameter "cls" (reportAttributeAccessIssue)
- /tmp/mypy_primer/projects/prefect/src/prefect/utilities/pydantic.py:163:19 - error: "__dispatch_key__" is not a known attribute of module "pydantic" (reportAttributeAccessIssue)
- 9099 errors, 252 warnings, 0 informations
+ 9097 errors, 252 warnings, 0 informations
manticore (https://github.com/trailofbits/manticore)
+ /tmp/mypy_primer/projects/manticore/manticore/core/workspace.py:339:9 - error: Method "load_value" overrides class "Store" in an incompatible manner
+ Return type mismatch: base method returns type "bytes | str", override returns type "Unknown | None"
+ Type "Unknown | None" is not assignable to type "bytes | str"
+ Type "None" is not assignable to type "bytes | str"
+ "None" is not assignable to "bytes"
+ "None" is not assignable to "str" (reportIncompatibleMethodOverride)
- Parameter 3 mismatch: base parameter "binary" is keyword parameter, override parameter is position-only (reportIncompatibleMethodOverride)
+ Parameter 3 mismatch: base parameter "binary" is keyword parameter, override parameter is position-only
+ Return type mismatch: base method returns type "bytes | str", override returns type "bytes | None"
+ Type "bytes | None" is not assignable to type "bytes | str"
+ Type "None" is not assignable to type "bytes | str"
+ "None" is not assignable to "bytes"
+ "None" is not assignable to "str" (reportIncompatibleMethodOverride)
- 25911 errors, 148 warnings, 0 informations
+ 25912 errors, 148 warnings, 0 informations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed and has no explicit return type annotation and the body references the decorated function in a loop. This addresses #9492.