Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] browserType.connect() promise never resolved after version 1.4.x #3991

Closed
ccpu opened this issue Sep 27, 2020 · 2 comments
Closed

[BUG] browserType.connect() promise never resolved after version 1.4.x #3991

ccpu opened this issue Sep 27, 2020 · 2 comments

Comments

@ccpu
Copy link

ccpu commented Sep 27, 2020

Context:

  • Playwright Version: 1.4.2
  • Operating System: Windows, Linux
  • Node.js version: 12.16.1
  • Browser: All
  • Extra: Using docker

After version 1.4.x the browserType.connect() never get resolved, it appears that the promis in this line never get resolved.

For remote browser, I am using this docker repo.

Docker image runs playwright version 1.4.2, i know that the problem is not docker image because when vscode debugger attached, I can see the playwright launch the server and pass it on from this line.

Also, I have managed to connect to the chromium-browser in docker running V 1.4.2 from 1.3.0 client. so I am assuming that the problem is not docker image.

Thanks!

@dgozman
Copy link
Contributor

dgozman commented Sep 30, 2020

Could it be that you rely on the specific wsEndpoint format or the shape of the remote protocol?

With 1.4 we switched to the new non-compatible protocol compared to 1.3. You can read about it in the "New Client / Server Wire protocol" section of release notes.

Note that if you launchServer with 1.4 and connect with 1.4 by passing wsEndpoint directly, it is supposed to work.

To help debugging, could you please run your server or client with DEBUG=pw:channel* and provide the logs?

@ccpu
Copy link
Author

ccpu commented Oct 10, 2020

i have had a chance to look into it today, the problem was not with playwright nor docker image, it was my mistake of using docker local registry wrongly, sorry for any inconvenient.

@ccpu ccpu closed this as completed Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants