Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UI Mode snapshot sometimes displays double #33940

Closed
agg23 opened this issue Dec 10, 2024 · 4 comments
Closed

[Bug]: UI Mode snapshot sometimes displays double #33940

agg23 opened this issue Dec 10, 2024 · 4 comments
Assignees
Labels

Comments

@agg23
Copy link
Contributor

agg23 commented Dec 10, 2024

Version

1.49.1

Steps to reproduce

  1. Create a test containing
await page.goto("https://github.com/");
await page.goto("https://github.com/");
  1. Run the test in UI Mode
  2. Hover over the entries for the gotos. Sometimes the second entry shows doubled UI elements, offset slightly

Image

Expected behavior

The snapshot display should be clean.

Actual behavior

Image

Additional context

No response

Environment

System:
    OS: Windows 11 10.0.26100
    CPU: (6) x64 Intel(R) Core(TM) i5-9500 CPU @ 3.00GHz
    Memory: 2.76 GB / 15.81 GB
  Binaries:
    Node: 20.17.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.22 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.8.2 - C:\Program Files\nodejs\npm.CMD
  IDEs:
    VSCode: 1.95.2 - C:\Users\agastineau\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
@agg23 agg23 self-assigned this Dec 10, 2024
@yury-s
Copy link
Member

yury-s commented Dec 10, 2024

Does it reproduce in trace viewer? If so, can you attach trace file?

@agg23
Copy link
Contributor Author

agg23 commented Dec 11, 2024

Does it reproduce in trace viewer? If so, can you attach trace file?

Good point. trace.zip. It does reproduce in the hosted version of Trace Viewer. It occurs on both Chrome and Firefox.

@microsoft microsoft deleted a comment Dec 11, 2024
@agg23
Copy link
Contributor Author

agg23 commented Dec 11, 2024

The current page at https://github.com has a canvas element surrounding the primary content at the top of the page. This is added explicitly in order to render these characters that animate on startup.

Image

<canvas class="lp-IntroVisuals-canvas" data-engine="three.js r148" width="1000" height="950" style="width: 1000px; height: 950px; opacity: 1; transform: scale(1);"></canvas>

Removing this element from the snapshot fixes the issue, which suggests snapshots are not actually capturing the contents of a canvas element at a given position, but rather the entire contents of the page in that bounding box. Additionally, the scaling must be slightly incorrect (non-deterministically?) to cause the doubled vision.

@yury-s yury-s added the v1.50 label Dec 11, 2024
@agg23
Copy link
Contributor Author

agg23 commented Dec 11, 2024

Add a checkbox to Trace Viewer to opt into canvas display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants