Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Pass timeout in the BrowserContextOptions for newContext #2363

Closed
mxschmitt opened this issue May 26, 2020 · 1 comment
Closed

Comments

@mxschmitt
Copy link
Member

It would ease up the usage especially in jest-playwright or other Playwright wrappers if we could pass the timeout for Playwright via the options. Maybe two timeouts, one for navigation and the other general one.
The original issue which this would ease up to solve is that the Jest timeout needs to be greater than the Playwright timeout. Otherwise Jest just stops the execution and no good error reporting will be generated out of that (which function call / Promise was not resolved).

As a workaround context.setDefaultTimeout() or context.setDefaultNavigationTimeout can be used.

@aslushnikov
Copy link
Collaborator

@mxschmitt looks like workaround is pretty decent and not painful. Let's keep it like this for now - we can always add these if there's an urge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants