Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Bypass CSP bit can be cached on Firefox #2316

Closed
pavelfeldman opened this issue May 20, 2020 · 1 comment
Closed

[BUG] Bypass CSP bit can be cached on Firefox #2316

pavelfeldman opened this issue May 20, 2020 · 1 comment
Assignees
@aslushnikov

Comments

@pavelfeldman
Copy link
Member

Added a failing capabilities test
@aslushnikov
Copy link
Collaborator

My investigation:

  • removing all our bypasscsp-checks (the docShell.bypassCSP) from firefox doesn't change anything
  • csp actually works if trying to navigate to assets/csp.html
  • csp actually works when trying to call page.addScriptTag

This happens since we currently disable CSP checks when running evaluate:

https://github.com/aslushnikov/juggler/blob/6bbb629c469c5c636efffe54cdd107f44dfb0092/js/src/debugger/Object.cpp#L2389-L2392

We might have a bug since the value might be cached:

https://github.com/aslushnikov/juggler/blob/6bbb629c469c5c636efffe54cdd107f44dfb0092/js/src/vm/GlobalObject.cpp#L834

@pavelfeldman pavelfeldman removed the v1.1 label May 28, 2020
@pavelfeldman pavelfeldman changed the title [BUG] Firefox does not respect CSP by default [BUG] Bypass CSP bit can be cached on Firefox May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslushnikov aslushnikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslushnikov @pavelfeldman