fix(browser_type): ignoreDefaultArgs in launch() (#190)

microsoft · Sep 14, 2020 · 54aabff · 54aabff
1 parent 992cd77
commit 54aabff
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/playwright/browser_type.py b/playwright/browser_type.py
@@ -132,10 +132,9 @@ def normalize_launch_params(params: Dict) -> None:
     if "env" in params:
         params["env"] = {name: str(value) for [name, value] in params["env"].items()}
     if "ignoreDefaultArgs" in params:
-        if isinstance(params["ignoreDefaultArgs"], bool):
+        if params["ignoreDefaultArgs"] is True:
             params["ignoreAllDefaultArgs"] = True
             del params["ignoreDefaultArgs"]
-        params["env"] = {name: str(value) for [name, value] in params["env"].items()}
     if "executablePath" in params:
         params["executablePath"] = str(Path(params["executablePath"]))
     if "downloadsPath" in params:

diff --git a/tests/async/test_issues.py b/tests/async/test_issues.py
@@ -0,0 +1,9 @@
+import pytest
+
+
+@pytest.mark.only_browser("chromium")
+async def test_issue_189(browser_type):
+    browser = await browser_type.launch(ignoreDefaultArgs=["--mute-audio"])
+    page = await browser.newPage()
+    assert await page.evaluate("1 + 1") == 2
+    await browser.close()