Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the PERFVIEW define #241

Open
sharwell opened this issue May 26, 2017 · 1 comment
Open

Remove the PERFVIEW define #241

sharwell opened this issue May 26, 2017 · 1 comment
Labels
enhancement Stale Issues that haven't been touched in 1 year.

Comments

@sharwell
Copy link
Member

DRAFT The PERFVIEW preprocessor define is no longer required. For all code which is not shared (using file links in the build) between both the PerfView and other projects, its value can be inlined to true (for the PerfView project) or false (for other projects). If at the end of this no more references to PERFVIEW exist, it can also be removed from the constants defined in PerfView.cs.

@vancem Can you review the above for accuracy before I implement it?

Copy link

Due to lack of recent activity, this issue has been labeled as 'stale'. It will be closed if no further activity occurs within 30 more days. Any new comment will remove the label.

@github-actions github-actions bot added the Stale Issues that haven't been touched in 1 year. label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Stale Issues that haven't been touched in 1 year.
Projects
None yet
Development

No branches or pull requests

1 participant