Align Rust API with C API and broaden functionality #15655
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original onnxruntime-rs has evolved both into the newly added Rust API bindings in ms/onnxruntime/rust and, separately, into a version by @seddonm1 that much more tightly mirrors the C API and includes significant additional functionality, such as IoBinding support.
This Draft PR is an effort to incorporate much of the work by @seddonm1 into ms/onnxruntime, while also including improvements from ms/onnxruntime, particularly around safety and Environment and Session management. Some reworking was done of the safety constructs in ms/onnxruntime to fit within the framework of OrtValues as first-class structs. Feedback from the community is greatly appreciated.
Motivation and Context
Safely handling OrtValues that own their data memory:
Safely handling OrtValues that do not own their data memory: