ORTModule support for kwargs input that is a dict #13910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
added
the
training
There was a problem hiding this comment.
Nice addition
@shubhambhokare1 might be interested in seeing a real use case for nested dicts
orttraining/orttraining/python/training/ortmodule/_inference_manager.py
Outdated
Show resolved
Hide resolved
pengwa
reviewed
Dec 12, 2022
pengwa
reviewed
Dec 12, 2022
| @@ -113,21 +135,15 @@ def __repr__(self) -> str: | |||
| \tRequire gradient: {self.require_grad_names} | |||
| \tDynamic axes: {self.dynamic_axes} | |||
| \tSchema: {self.schema} | |||
| \t#Positionals (total): {self.num_positionals} | |||
| \t#Expanded Positionals (non-None): {self.num_expanded_positionals_non_none} | |||
| \tKeyword names: {self.keyword_names}""" | |||
There was a problem hiding this comment.
By not printing the captured names, we make debugging of scenarios with kwargs harder
There was a problem hiding this comment.
I agree. Let me merge this change to unblock a model, and I will create a follow up PR to add the flattened keyword names as part of the InputInfo.
henrywu2019
pushed a commit
to henrywu2019/onnxruntime
that referenced
this pull request
Dec 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORTModulehas support*args, **kwargssince it was added earlier.ORTModulealso has support for nested lists and dictionaries.However, it does not support model inputs that are a part of
**kwargsas well as aredicts. This was probably not thought of as support needed earlier. A model that @frank-dong-ms has been working on needs this support.With this pull-request, ORTModule can successfully run such models.
contributors: @frank-dong-ms, @baijumeswani