Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Documentation on how to coordinate the external Onnxruntime-Extension #11655

Open
GeorgeS2019 opened this issue May 27, 2022 · 7 comments
Open
Labels
documentation improvements or additions to documentation; typically submitted using template

Comments

@GeorgeS2019
Copy link

GeorgeS2019 commented May 27, 2022

Is your feature request related to a problem? Please describe.
Onnxruntime refers to the external repository Onnxruntime-Extension which is 9 month old. It is unclear what benefits to include the latest master branch of Onnxruntime-Extension. It is unclear for a given issue using Onnxruntime-extension in c#, which repository, onnxruntime or onnxruntime-extension to file an issue.

There are no samples or test for c# in onnxruntime-extension repo. Most of them are in c++
image

There is one test for c# related to onnxruntime-extension in onnxruntime csharp folder.
image

System information

  • ONNX Runtime version (latest):

Describe the solution you'd like

We need an improvement supporting C# Custom Op development experience.

[First]
We need to address these feature requests

to support better c# for onnxruntime-extension development experience.

[Second]
We need documentation and if possible c# project which combines c++ custom opt dll generation and the c# test project to test-driven the generated custom opt dll.

@GeorgeS2019
Copy link
Author

The documentation could also include a reference to how to generate the custom op dll and onnx in pytorch and make that available in c# as a sample

@GeorgeS2019
Copy link
Author

@GeorgeS2019
Copy link
Author

GeorgeS2019 commented Jun 3, 2022

@wenbingl

A number of open issues in onnxruntime-extension can now be answered by e.g. csharp unit test here

@GeorgeS2019
Copy link
Author

There is a need to clarify that the onnxruntime-extension repository to coordinate the development of contributed operators to be eventually integrated and embedded into the onnxruntime

@GeorgeS2019
Copy link
Author

Related discussion: [C# Windows] Standardize the name of ortcustomops.dll

@GeorgeS2019
Copy link
Author

image

The onnxruntime-extension deals with c api and how python access the contributed and custom operators

Onnxruntime provides the application interface for e.g. c#, java and c++ wrappers around the c api => developed in onnxruntime-extension for working with extended contributed and custom operators

@natke
Copy link
Contributor

natke commented Mar 22, 2023

Hi @GeorgeS2019,

You can see an example of the extensions library being used in this tutorial: https://onnxruntime.ai/docs/tutorials/csharp/stable-diffusion-csharp.html. The DLL is included in the source code and loaded directly. In the upcoming release we will include a C# package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation; typically submitted using template
Projects
None yet
Development

No branches or pull requests

3 participants