-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question: supported nodejs versions #557
Comments
This is silly. LTS (eg 16.x, 18.x, 20.x) within a reasonable timeframe of their release is a fair request/assumption as long as this is considered an active project however attempting to support every release in between would slow down bug resolution and development too much. This is non-revenue-generating project for Microsoft so let's dial down our expectations on bleeding edge releases... |
@z3bra5hax Then does Thanks. |
The project will support LTS when it is updated to do so. This project isn't specifically a high priority from microsofts perspective I imagine, so it relies on FOSS developers to add support for LTS versions. I am currently working on support, but there is no specific date for when that may be done(could be a month, could be years). |
This is true, currently we support whatever node.js version VS Code's Electron is on which is currently 16 (soon to be updated). I agree this is suboptimal, but I'm also busy maintaining xterm.js and the terminal and many other features in vscode. To add to this, I'm admittedly not that great with C++ so the amount of effort it takes me to review changes is much higher. The readme says Node 12+ which is inaccurate so I'll update that to reflect the current situation. |
The #644 will make this project support from node 16 to 21, you can download & replace to test, see the message in that PR. |
Hi!
Thanks for this project :)
May I ask which nodejs versions
node-pty
supports?(
node-pty
's package.json does not haveengines
field.)For example, I saw some (closed) issues saying like "node 17 is not supported", or "installation failed in node 15".
I want to use
node-pty
in my open-source project.But the project should support every recent nodejs versions.
(e.g.
node>=16
: 16.x, 17.x, 18.x, 19.x, 20.x)What's more, once a new nodejs version is released(e.g. 21.x(future)), my package should become ready for the runtime as soon as possible.
Would it be possible?
Thanks!
The text was updated successfully, but these errors were encountered: