add optional support to replace argv[0] (fixes #472) #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Hey y’all, let me know if anything’s missing, but I’ve been using this for quite some time now day-to-day and haven’t seen any issues. |
mattieb
force-pushed
the
add-argv0-support
branch
from
6438f41 to
7fe4faa
Compare
mattieb
force-pushed
the
add-argv0-support
branch
from
f3e7b87 to
dc816f2
Compare
|
Hey folks, sorry for the churn today. I've been keeping this PR up-to-date with main for 1½ years now, while the code around what I've changed has been evolving. I've most recently done this because I was running package updates in my project that uses this support and needed to pull in the upgrades y'all have been making. Is there a chance we could evaluate this relatively simple PR and merge it? I think it's a feature that many folks would find useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472.
With this, specifying the new property "argv0" in options will replace argv[0] with a custom string.
This is useful, for example, when starting a login shell:
If this property is omitted, the file parameter is used instead, which is identical to existing behavior.