Allow for array modifications, add inPlace formatting option.

[mbullington]

Hello!

• Allow for array modifications, with proper bounds checking.
• Add inPlace option for formatting options (disabled by default), which essentially is a shortcut past withFormatting. This can be helpful for very large data files where performance is more important than file formatting.

Thanks again for this great library!

[aeschli]

Thanks.
We have the same code in vscode and insertions got implemented there
microsoft/vscode@fa2eff9#diff-0a43f142588962451d1bba0023dff15d

I want to bring the two together. If you are interested doing so that would be great.

[mbullington]

Sure, I'm happy to help unify the two but would like some feedback on how to proceed.

In VSCode, the commit you mentioned supports adding an element to the array at a specific index. This PR, when given an already existing index, will replace that index's content.

Perhaps a replacement policy option to support both use cases?

[aeschli]

Agree, we need something to distinguish the cases. Replace should be the default.
Possibilities

• allow to use fractions: [1.5] to insert between 1 and two
• have a ModificationOptions.isInsert

[mbullington]

Just updated to include a ModificationOptions.isArrayInsertion option that is false by default, and also co-oped the unit tests from microsoft/vscode@fa2eff9#diff-0a43f142588962451d1bba0023dff15d. My only concern is that if VSCode syncs the code from this repo (or if they have diverged?), the default of replacement is different and may cause issues.

[stevenguh]

Thank you guys. I happen to need this feature. I am wondering is there any update on this?

[aeschli]

Thanks @mbullington !

[stevenguh]

@aeschli I don't mean to be pushy, but I am wondering is there a timeline for a new release that has this change? Thank you

[aeschli]

Published [email protected]

Note: I removed FormattingOptions.inPlace. Instead, ModificationOptions.formattingOptions is now optional. If not set, newly inserted content will not be formatted.