-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text truncated on copy with "..." ellipsis #1540
Comments
Note that this is still an issue in v 0.17.0 |
Note the we litterally have an Ellipsis codepoint |
@alexandrudima as the main author, would you by chance have an idea of where to look for in the code to fix this? Thank you in advance! This is a pending bug in clearlydefined/website#799 which happens to be sponsored and used also by MSFT and GH FWIW. And that same issue exists in Azure pipelines when viewing logs: you cannot copy them... the copy is truncated. |
Currently the selection clipboard is not supported in linux. Let's track in #1458 |
Also this ticket is about Firefox on Linux. There is no issue on Chrome for this. So this is browser specific and not only Linux. #1458 is about Chrome and I cannot reproduce the issue at play here in Chrome. |
@pombredanne Here is where we write ellipsis to the hidden That is the text that is placed in the hidden Can you please clarify your steps? How do you copy the text and paste it in the sentence: "Copy some long enough text ... and paste it" Are you using:
|
@alexdima here is the sequence of events on Firefox 70.0.1 (64-bit) on Ubuntu 16.04 LTS:
With this sequence, the pasted text is truncated and there is a ellipsis For 5. I can use instead ( I am not using the selection clipboard nor middle mouse click (in fact this is an X "feature" that is disabled in most Linux desktop these days AFAIK and disabled on mine by default). |
@pombredanne I cannot reproduce. I have tried:
I have tried with Firefox 70.0.1 (64-bit) on Ubuntu 19.10 |
Doing the same thing I get this paste:
|
We can have a screen sharing session at your convenience if that can help you debug this. |
@pombredanne Have you customized your FF profile in any way, such as to disable clipboard APIs? Can you please first attempt to reproduce with a clean FF profile and without any extensions? Does this reproduce for you on Chromium on the same machine? Can you reproduce in the page at https://vscode-web-test-playground.azurewebsites.net/ (that one has a more up-to-date version of the editor). |
Can you also please try running the following fiddle -- https://jsfiddle.net/4mv1wrab/
For me, the console says Thank you! |
@alexdima you nailed it and I am very sorry for having wasted your time here. The culprit are my settings. I have checked my config and found that the setting Things works also fine as-is in Chrome and Chromium. Please accept my apologies and thank you for your patience! |
No problem, glad I could help. |
monaco-editor version: See below
Browser: Firefox 68.0.1 (64-bit)
OS: Linux
Steps or JS usage snippet reproducing the issue:
Copy some long enough text ... and paste it: it gets truncated in the middle with dot dot dot ellipsis. On Chrome this is not truncated. Only on FF.
This seems to be closely related to #1458
This is the version used in ClearlyDefined: https://clearlydefined.io/vs/editor/editor.main.js
This is the version used in Azure: https://cdn.vsassets.io/3rdParty/_content/Extensions/CodeEditor/0.13.1.1/vs/editor/editor.main.js
The text was updated successfully, but these errors were encountered: