Skip to content
This repository has been archived by the owner on Jun 10, 2022. It is now read-only.

Transform updates not propagating for attachments when using subscription 'transform' #739

Open
David032 opened this issue Mar 12, 2021 · 1 comment

Comments

@David032
Copy link

It was flagged in the MRE-SDK discord here that transform updates do not propagate to attachments when using the subscription 'transform'. A fix has been found but as it requires either the modification of the built code in the node_modules folder (Lines 186 through to the next '{' of rules.js) or the sdk itself (403-406 of rules.ts) it's not viable for most deployments.

The fix:
const syncActor = session.actorSet.get(message.payload.actor.id); const attachment = syncActor.initialization.message.payload.actor.attachment; if (syncActor && ((client.authoritative && !syncActor.grabbedBy) || (syncActor.grabbedBy === client.id) || (attachment && attachment.userId === client.userId))) {

@amoringello
Copy link

amoringello commented Mar 14, 2021

The fix works locally but like stated, that is not a viable plan for deployment. It needs to be in the SDK. I'm stuck running on localhost-only where I can make the changes myself. This needs to

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants