-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: TimePicker should be split into single digits again. #905
Comments
Typing the time doesn't help someone using a tablet. |
If the proposal is accepted, I would not want it to become the default. I think it should be a property of the control. |
I'm with @mdtauk . Yes, the split digits could help the tablet users (could because the only real tablet OS out there - iOS - uses the compact digit and no one has complained) but it can be a secondary and optional mode, to not trouble those apps that are geared to the desktop. |
I had an internal proposal similar to this a while ago. It was basically a proposal to change TimePicker to three ComboBoxes "linked" together seamlessly. That meant that inherited properties like IsEditable would come along, but the base control would operate as you'd expect with keyboard, mouse and touch - because ComboBox works nicely with all three. |
@kikisaints that's is an interesting approach. The chevrons do add some bulk, which could be massaged with a design similar to the ones I explored. It doesn't quite address the issue in the proposal, as they wanted to avoid long scrolls for the minutes, by having the two digits of the minutes separate. But like the proposal for an Editable Date Picker, an Editable Time Picker, would fill the control suite out nicely. Does IsEditable become a property on the existing controls, or should they be new controls? What was the conclusion of that internal proposal? |
Ah I misunderstood the original proposal a bit. @shaheedmalik What scenario(s) were you thinking that having the 1s and 10s places' separate would solve? I'm curious if you have a particular need here besides ease of use/nice to have. @mdtauk the proposal in general was agreed upon as an improvement, but we didn't have the dev resources to act on it, so it was moved "out" and has not been revisited since. Additionally, depending on how the "new" timepicker inherited from ComboBox, it would be a property on the "new" control. Which in this proposal is just a re-skin of ComboBox. If that's what you meant? |
I like the current design with loop-around scrolling and auto-selection based on the currently highlighted item. It is good for touch and mouse wheels with infinite scroll (where the wheel rotates freely without clicking). I understand though that if your mouse wheel requires a click for each digit change then it could be annoying. Split digits for minutes/seconds adds extra input steps and clutters the UI. Combo boxes require both scrolling and selection, plus the chevrons are not attractive. I agree with @mdtauk that accepting keyboard input would be the most helpful addition, and this would not take a step backwards from the current design - depending on what input method is being used. The main design consideration for keyboard input would be how to indicate which part of the TimerPicker has focus, and how to change focus. |
@kikisaints With it all going Open Source - that makes the proposal more likely to happen. WinUI 3.0's initial release is the priority for now, but don't abandon the idea. |
Proposal: [TimePicker should be split back into into single digits again.]
Summary
The TimePicker as currently designed takes way to long to select the wanted time using touch, keyboard, and mouse devices
Rationale
Scope
Important Notes
Open Questions
The text was updated successfully, but these errors were encountered: