-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WinUI3 Reunion 0.5] "ExtendsContentIntoTitleBar" Hides Min/Max/Close Buttons #4835
Comments
@pratikone and @Austin-Lamb FYI |
Dup of #4209? |
Hi @codendone , Same bug, new issue for more recent release with an updated solution! We have been updating to each of the releases to test and track changes in bugs and functionality. This issue is for the most recent release of Reunion 0.5 while the other issue is for Preview 4. Thanks again! |
Thanks @eleanorleffler, |
I'm glad to hear that a fix will be coming for this. In the meantime, are there any workarounds for this issue? |
It appears this issue is still not fixed. Using: 0.8 preview |
Reunion 0.8 released, issues still remains. To be specific, in a window that uses ExtendsContentIntoTitleBar, the content, typically a grid, extends over the top of chrome buttons and titlebar. If the grids background is null, then the buttons still work and respond visually as expected, however, if the grid's background is set (to a color or image) then this covers the chrome buttons; they will no longer respond to mouse input or display (they are basically underneath the grid). I'm assuming to fix this, the buttons (and drag drop area) need to be brought to the top (on top of the grid). |
Hi all, thanks for bringing this issue out. We found some bugs to fix in this area and some design related restrictions We have catalogued those here : https://docs.microsoft.com/en-us/windows/winui/api/microsoft.ui.xaml.window.settitlebar?view=winui-3.0#Microsoft_UI_Xaml_Window_SetTitleBar_Microsoft_UI_Xaml_UIElement_ Please follow them and see if they fix anything. Some of the changes include : not setting background property on custom titlebar uielement as it draws over the min/max/close. By default, the custom titlebar will take the accent colors set in your Windows settings. If you want to customize the theme of custom titlebar, they can be overridden by changing resource values of some brushes. (I will check and post the name of those brushes here) Edit : we have some more docs which need to be added on the MSDN page. Second edit : the new documentation is now live. It contains the resources to theme the custom titlebar and a list of restrictions on how to use the custom titlebar feature which you might be hitting https://docs.microsoft.com/en-us/windows/winui/api/microsoft.ui.xaml.window.settitlebar?view=winui-3.0#Microsoft_UI_Xaml_Window_SetTitleBar_Microsoft_UI_Xaml_UIElement_ |
@pratikone Thanks for the updates. I tried the scenarios with blank app based on your guidance. I could extend the content on title bar and provide interactive elements (Button "Hey 1" ) on the left area only. Please confirm on below?
Bug
Please do let me know if any more data is needed. |
Thanks for providing all these scenarios. We are aware of this specific feature request which one can call as non contiguous custom titlebar or having interactable elements within titlebar. Both have the same root. There are discussions ongoing on best ways to support these scenarios |
A workaround is described here #4166 |
@schemburkar can you open another issue with your screenshots ? - it will be helpful to track that issue separately. Closing this one for now as it has been answered |
Thanks @pratikone, created #6070. Let me know if you need more details on that thread. |
Describe the bug
In WinUI 3 Reunion 0.5, using "ExtendsContentIntoTitleBar" when the background is set on the
control to be used as the title bar results in the standard action buttons on the window
(minimize, maximize, close) being hidden.
Additionally, the action buttons are a smaller height when "ExtendsContentIntoTitleBar" is used.
In UWP, this was accomplished with code like this:
Steps to reproduce the bug
Expected behavior
We expect to be able to customize the TitleBar without losing the standard window buttons.
Screenshots
Current (WinUI3 Desktop) vs. Expected (UWP) - Setting TitleBar to Blue
Current (WinUI3 Desktop) vs. Expected (UWP) - Setting TitleBar to No Color
Version Info
Targeting:
Target: Universal Windows
Target version: Windows 10, version 2004 (10.0; Build19041)
Min version: Windows 10, version 1809 (10.0; Build 17763)
NuGet package version:
[Microsoft.ProjectReunion 0.5.0]
[Microsoft.ProjectReunion.WinUI 0.5.0]
Windows app type:
Additional context
The text was updated successfully, but these errors were encountered: