Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Adding DataGrid in WinUI 3 Alpha Page #1860

Closed
infoequipt opened this issue Jan 18, 2020 · 8 comments
Closed

Error Adding DataGrid in WinUI 3 Alpha Page #1860

infoequipt opened this issue Jan 18, 2020 · 8 comments
Assignees

Comments

@infoequipt
Copy link

XamlCompiler error WMC0020: Cannot add 'DataGrid' into the collection property 'Children', type must be 'UIElement'

Create a new project using the WinUI 3.0 Alpha C# "Blank App (WinUI UWP)" template.
Add [Microsoft.Toolkit.Uwp.UI.Controls] DataGrid to Page.

VS 2019 Community 16.4.3
Microsoft.WinUI v3.0.0-alpha.191101.0
Microsoft.Toolkit.Uwp.UI.Controls.DataGrid v6.0.0
Windows 10 Version 1903 10.0.18362

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jan 18, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 18, 2020

@infoequipt The data grid in the toolkit is built on top of the platform xaml (Windows.Ui.Xaml). WinUI3 is the same XAML codebase that has been decoupled from the OS (and has an updated namespace Microsoft.UI.Xaml). The reason I believe you are seeing is that the datagrid is not compiled against WinUI3. We need a version of the toolkit that targets WinUI3 for that to work. @nmetulev and @MikeHillberg This might make sense to track in the toolkit repo.

@ranjeshj ranjeshj added the team-Controls Issue for the Controls team label Jan 18, 2020
@infoequipt
Copy link
Author

infoequipt commented Jan 19, 2020

Thanks Ranjesh, I thought that might be the case.

@nmetulev
Copy link
Member

Ping @michael-hawker

@lukeblevins
Copy link
Contributor

Hopefully, there will be work started on a new DataGrid before the stable release of WinUI 3 Desktop.

@StephenLPeters
Copy link
Contributor

This should be extended to all of the toolkit, not just data grid.

@StephenLPeters StephenLPeters removed needs-triage Issue needs to be triaged by the area owners team-Controls Issue for the Controls team labels Jan 22, 2020
@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jan 22, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented Jan 22, 2020

I filed a bug in Windows Community toolkit to track this.
CommunityToolkit/WindowsCommunityToolkit#3106

@Austin-Lamb @MikeHillberg @michael-hawker as FYI.

@msft-github-bot msft-github-bot removed the needs-triage Issue needs to be triaged by the area owners label Jan 22, 2020
@azchohfi
Copy link
Contributor

I did push a branch of the toolkit that supports that, but it's in very early stages, and not everything is ported.
https://github.com/windows-toolkit/WindowsCommunityToolkit/tree/winui
This is something that we will definitely support on the toolkit once winui3 is stable.

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jan 22, 2020
@ranjeshj
Copy link
Contributor

@azchohfi That is awesome ! Thanks.

@msft-github-bot msft-github-bot removed the needs-triage Issue needs to be triaged by the area owners label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants