Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__CxxFrameHandler4 API is causing Microsoft Store certification failure, thus blocking all app store updates #1446

Closed
dpaulino opened this issue Oct 15, 2019 · 23 comments
Assignees
Labels
team-Controls Issue for the Controls team

Comments

@dpaulino
Copy link
Contributor

dpaulino commented Oct 15, 2019

Describe the bug

All UWP apps submitted to the Microsoft Store must pass certification. There seems to be a bug in the WinUI library that is causing all UWP apps that use WinUI to fail Store certification due to an unsupported API. Here is a certification report that I received from the Store team (and I also reproduced this report locally on my machine using the Windows App Certification Kit):
image

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Ensure you are logged into VS2019 with a Microsoft Account that has UWP apps available in the Windows Developer Dashboard (https://partner.microsoft.com/en-us/dashboard/windows/overview).
  2. Download this repo and launch the solution in VS2019: https://github.com/dpaulino/winui-unsupported-api
  3. In solution explorer, right click on the project name UnsupportedApiTest (Universal Windows)
  4. Select publish > create app package
  5. Now we just need Visual Studio to create a signed package. So when the app package wizard pops up, select the option to associate the project with a Microsoft Store app. Select any app (it doesn't matter which app since we are not going to upload the package).
    image
  6. Leave the defaults on this screen:
    image
  7. Click create.
  8. After the package is created, Visual Studio will launch a pop up window asking you if you want to launch the app certification kit. Click launch.
  9. In the app cert kit, follow instructions to run the kit.
  10. Eventually, the kit should result in a failure:
    image
  11. This should be one of them:
    image

Expected behavior

There should be no error related to unsupported APIs

Screenshots

See above

Version Info

NuGet package version:

2.3.191007001-prerelease

Windows 10 version Saw the problem?
Insider Build (xxxxx)
May 2019 Update (18362) Yes
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop Yes
Mobile
Xbox
Surface Hub
IoT

Additional context
2.3.190910001-prerelease does not have this same problem.

@jevansaks jevansaks self-assigned this Oct 15, 2019
@msft-github-bot msft-github-bot added the needs-assignee-attention Assignee needs to follow-up or investigate this issue label Oct 15, 2019
@dpaulino
Copy link
Contributor Author

@jevansaks when you marked this as needs: follow-up, do you need anything from me?

@jevansaks
Copy link
Member

@jevansaks Jevan Saks FTE when you marked this as needs: follow-up, do you need anything from me?

That's for me, thanks!

I was following up with the WACK team and they told me that this is a regression that the Store is hoping to fix this week. Hopefully you can just use the older WinUI version while you wait? I don't know if it's worth releasing a nuget package with a workaround if it should be fixed that soon.

@dpaulino
Copy link
Contributor Author

No, don't worry about releasing another package with a workaround since this issue is only affecting the prerelease package.

Is there somewhere I can track the progress of that WACK bug?

@jevansaks
Copy link
Member

Let's just use this issue -- I'll post back here when I hear that it's fixed.

@dpaulino
Copy link
Contributor Author

Sounds good. I appreciate your help with this.

@jevansaks
Copy link
Member

This issue should be resolved now. Can you try re-submitting to the store?

@msft-github-bot msft-github-bot removed the needs-assignee-attention Assignee needs to follow-up or investigate this issue label Oct 17, 2019
@dpaulino
Copy link
Contributor Author

Thank you for the update! I'll try re-submitting today or tomorrow

@jevansaks
Copy link
Member

Oh and just to clarify, the locally run WACK will continue to fail until the fix is incorporated into the Insider SDK. But the store submissions should be unblocked.

@hippieZhou
Copy link

@dpaulino ,I still have this issue when updated.

Snipaste_2019-11-26_11-10-16

Snipaste_2019-11-26_11-08-31

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Nov 26, 2019
@dpaulino
Copy link
Contributor Author

@hippieZhou Are you seeing the error in the local Windows App Certification Kit (WACK) tool or are you seeing the error from the Dev Centre Portal after submitting your app package?

If you are seeing the error in the local WACK tool, then you can ignore the error. The WACK tool does not have the bugfix, but the Dev Centre Portal DOES have the bugfix.

@hippieZhou
Copy link

@dpaoliello ,thanks for your help. I'm trying to submit it to the Dev Center.

@solomonfried
Copy link

This still fails in the WACK 10.0.18362.1
Is there a fix in the works? Has a new version of the SDK been released or announced?

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Feb 27, 2020
@jevansaks
Copy link
Member

I think the fix is only in the insider SDK, not the 18362 SDK. Sorry, I don't have any more info at the moment. Is this blocking your CI pipelines or store submissions?

@msft-github-bot msft-github-bot removed the needs-triage Issue needs to be triaged by the area owners label Feb 27, 2020
@solomonfried
Copy link

Just wondering, This issue has been open since late 2019. There have been several updates to VS2019 since then but the WACK is still at 10.0.18362.1
Will there ever be an update to get rid of the false "Fail" report?

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Apr 2, 2020
@ranjeshj
Copy link
Contributor

ranjeshj commented Apr 2, 2020

@MikeHillberg @Austin-Lamb do you know the answer or can you route @solomonfried 's question ?

@msft-github-bot msft-github-bot removed the needs-triage Issue needs to be triaged by the area owners label Apr 2, 2020
@KevinLaMS
Copy link

Greetings @solomonfried
Sorry about the delay. This has been fixed in the latest Windows App Certification Kit that will ship in the next Windows SDK. We have also updated the test already in the Windows Store. So your store submission will not fail due to this API.
Sorry for the inconvenience.

Kevin

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Apr 2, 2020
@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Apr 3, 2020
@StephenLPeters StephenLPeters added needs-triage Issue needs to be triaged by the area owners and removed needs-triage Issue needs to be triaged by the area owners labels Apr 6, 2020
@DiverseTGM
Copy link

image

Im getting this error still.

@mc0re
Copy link

mc0re commented Jul 11, 2020

How can I submit to the store if WACK failed? There is no "Submit" button on it...

@msft-github-bot msft-github-bot added the needs-triage Issue needs to be triaged by the area owners label Jul 11, 2020
@grork
Copy link

grork commented Jul 12, 2020

If you build the package for store upload, you can skip running the WACK tests, and then just submit the .appxupload to the store through the store dashboard (https://partner.microsoft.com/en-us/dashboard/windows/overview)

@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Jul 13, 2020
@DevEddy
Copy link

DevEddy commented Nov 17, 2020

I still get this error, any updates?
Any updates on this?

@DiverseTGM have you resolved the issue?

-- Eddy

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 17, 2020
@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Nov 18, 2020
@ShaneOss
Copy link

I'm also seeing the issue. Seems it's been around for about a year now. Any ETA on fix for WACK tool? So workaround is build without certifying and upload package manually to dev portal?
Also seeing another false positive of... Error Found: The high OS version validation detected the following errors:
Task failed to enable HighVersionLie.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jan 11, 2021
@ranjeshj
Copy link
Contributor

@KevinLaMS FYI

@ghost ghost removed the needs-triage Issue needs to be triaged by the area owners label Jan 12, 2021
@ranjeshj ranjeshj added needs-triage Issue needs to be triaged by the area owners and removed needs-triage Issue needs to be triaged by the area owners labels Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests