Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version with support for LSP 3.18 #369

Closed
rowillia opened this issue Aug 2, 2024 · 3 comments
Closed

Publish new version with support for LSP 3.18 #369

rowillia opened this issue Aug 2, 2024 · 3 comments
Assignees

Comments

@rowillia
Copy link

rowillia commented Aug 2, 2024

Hi all,

Do mind publishing a new release to pypi w/ support for LSP 3.18? I see you recently updated main for 3.18 and I'd love to try some of the new features like SnippetTextEdit.

Thanks!

@karthiknadig
Copy link
Member

Yes we will publish soon. Doing some internal testing.

@karthiknadig karthiknadig self-assigned this Aug 2, 2024
@rowillia
Copy link
Author

rowillia commented Aug 2, 2024

Great to hear @karthiknadig !

When trying to move to migrate pygls to the latest version I noticed there have been a lot of breakages since the package was last published (e.g. WorkspaceConfigurationParams => ConfigurationParams, TraceValues => TraceValue, TextDocumentContentChangeEvent_Type1 => TextDocumentContentChangePartial).

Is there way to have a compatibility shim to make the update easier? Are the set of changes documented anywhere?

Since pygls depends on the lsprotocol types this would also require changes to all existing extensions (several of which were written by Microsoft)

@karthiknadig
Copy link
Member

Published a pre-release version with new LSP 3.18. I also updated pygls see here: openlawlibrary/pygls#487

They are both pinned to specific versions, and I plan to update Microsoft extensions to use the new pygls once it has a stable release.

@karthiknadig karthiknadig closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants