Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle text based media type responses. #302

Closed
Tracked by #1049
darrelmiller opened this issue Jul 5, 2021 · 2 comments · Fixed by #1471
Closed
Tracked by #1049

Handle text based media type responses. #302

darrelmiller opened this issue Jul 5, 2021 · 2 comments · Fixed by #1471
Assignees
Labels
enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities.

Comments

@darrelmiller
Copy link
Member

darrelmiller commented Jul 5, 2021

If the response is text/html or text/csv, for example, we should ensure the user can access the response payload easily.

Response type in the RequestBuilder method should probably be Stream so that we can handle large responses.
AB#10130

@darrelmiller darrelmiller added the enhancement New feature or request label Jul 5, 2021
@darrelmiller darrelmiller added this to the Beta milestone Jul 5, 2021
@baywet baywet self-assigned this Jul 5, 2021
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Jul 21, 2021
@baywet baywet moved this to Todo in Kiota Feb 18, 2022
@baywet baywet moved this from Todo to In Progress in Kiota Mar 30, 2022
@baywet
Copy link
Member

baywet commented Mar 30, 2022

For this one the plan is that anything that's not text/plain, text/xml, text/yaml, application/xml, application/json or anything that doesn't have a schema will be treated as stream. The only exception being text/plain without schema will be treated as string.
I'm going to tackle this together with #546

@baywet
Copy link
Member

baywet commented Mar 31, 2022

fixed via #1471

@baywet baywet added the fixed label Mar 31, 2022
Repository owner moved this from In Progress to Done in Kiota Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants