Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default valid hostnames values and default scope value in the access token provider should be defined in graph core #1063

Closed
baywet opened this issue Jan 24, 2022 · 5 comments
Assignees
Labels
Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java
Milestone

Comments

@baywet
Copy link
Member

baywet commented Jan 24, 2022

default valid hostnames values and default scope value in the access token provider should be defined in graph core

Originally posted by @baywet in #1051 (comment)

We should move https://graph.microsoft.com/.default and graph.microsoft.com

@baywet baywet self-assigned this Jan 24, 2022
@baywet baywet added this to the TypeWriter Replacement milestone Jan 24, 2022
@baywet baywet added Csharp Pull requests that update .net code Go Java TypeScript Pull requests that update Javascript code labels Jan 24, 2022
@nikithauc
Copy link
Contributor

I will incorporate the typescript changes for the core part as I am already working on the auth part in core. And marking this issue in the Graph core for JavaScript

@ddyett
Copy link
Member

ddyett commented Mar 16, 2022

@baywet is this tracking work each team needs to cover or general kiota work.

@baywet
Copy link
Member Author

baywet commented Mar 16, 2022

I'm not sure anything needs to happen in Kiota itself anymore at this point. Maybe a little change in behaviour, if there are no valid hostnames, all the host names are valid (instead of nothing valid)?
For the scopes, maybe we could set a generic OpenId scope here as a default?
And then the work that needs to happen is to set the defaults in Graph cores instead.

@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Jan 9, 2023
@baywet baywet added this to Kiota Jan 9, 2023
@baywet baywet moved this to Todo in Kiota Jan 9, 2023
@baywet
Copy link
Member Author

baywet commented Jan 10, 2023

After some additional research the best course of actions is probably:

  • To have a default scope of <scheme>://<host>/.default used in the GetAuthorizationTokenAsync method of the azure access token provider. This way it'll also work for national clouds or other APIs secured with MIP.
  • To have the allowed host validator validate when no hosts are provided. (already the case in .net)
  • To have default hosts defined with a derived authentication provider in graph core and removed from the kiota lib.

@baywet
Copy link
Member Author

baywet commented Jan 17, 2023

TODO:

  • test out ruby changes
  • update readmes for go/ruby service libs
  • create issues for php/python/swift
  • update public docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code generator Issues or improvements relater to generation capabilities. Go Java
Projects
Archived in project
Development

No branches or pull requests

3 participants