-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector needs to have config validators #372
Comments
@ryancrawcour I see the following in
This implies that a readonly key could also be used to create the client. Is there a good way to validate that the client is created with a master key containing required ALL permission to create/write to database/container? |
that's a good point. i forget about the read-only key. @kushagraThapar / @moderakh can you think of a way to validate the key being used has write permission to the container, without actually attempting to write a doc (and then having to delete it). |
@ryancrawcour I don't have a lot of knowledge on this but would the permissions API help here? https://docs.microsoft.com/en-us/rest/api/cosmos-db/permissions . This can work only if we can invoke without any additional credentials or permissions. |
@mageshn no permission API purpose is different. At client side we currently do not have any API to distinguish a write key from a read key without actually attempting to perform a write operation. I will check with our service side team if there is any workaround. |
i have the following listed as validators to add - validate database name is valid
validation container name is valid
@moderakh / @kushagraThapar thoughts on the above 2 operations? validate that the topic(s) are valid
any others? |
doesn't look like there is a way to determine write permissions given a key without actually attempting to write a doc. |
## Problem Statement
When entering configuration for the connector it would be great if these config values could be validated whilst registering the connector instead of @ runtime when the connector tries to start.
## Proposed Solution
Kafka Connect supports connector config validation. Implement this for the sink connector config properties.
Ensure common, Sink and Source config values all have validators and recommendors as appropriate.
Validations to add -
## Additional context
https://www.confluent.io/blog/write-a-kafka-connect-connector-with-configuration-handling/
Next Steps
The text was updated successfully, but these errors were encountered: