-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-design GetAttributeAtVertex #181
Comments
(cc @Keenuts, @sudonatalie, @tex3d) I filed this to track our need to spend some time designing an alternate solution at the language level to handle |
Do you happen to know how the DXIL side is usually implemented? And why we haven't required the input of On the SPIR-V Side, the shader ends up with a array as input.
So if the HLSL type was an actual array, it would be quite easy to support this feature correctly. |
The DXIL side of this is totally magic (and buggy). We don't actually represent the parameter as anything but the specified source type. The presence of the attributes is implied in DXIL not represented. |
Is your feature request related to a problem? Please describe.
The current implementation of GetAttributeAtVertex has bugs which are products of the design rather than just the implementation:
GetAttributeAtVertex
aren't counted as read in the signature DirectXShaderCompiler#5417Describe the solution you'd like
We need to design a different approach to this feature that doesn't rely on compiler optimization to guarantee correctness.
Describe alternatives you've considered
The text was updated successfully, but these errors were encountered: