From 8988f83bc22feb73e6f66878e3a295a792b7c7ef Mon Sep 17 00:00:00 2001 From: Steve Sanders Date: Tue, 30 Oct 2018 14:07:09 -0700 Subject: [PATCH] avoid SetFileCompletionNotificationModes crash --- file.go | 52 +++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/file.go b/file.go index 4334ff1c..cfaf1843 100644 --- a/file.go +++ b/file.go @@ -10,6 +10,7 @@ import ( "sync/atomic" "syscall" "time" + "unsafe" ) //sys cancelIoEx(file syscall.Handle, o *syscall.Overlapped) (err error) = CancelIoEx @@ -17,6 +18,48 @@ import ( //sys getQueuedCompletionStatus(port syscall.Handle, bytes *uint32, key *uintptr, o **ioOperation, timeout uint32) (err error) = GetQueuedCompletionStatus //sys setFileCompletionNotificationModes(h syscall.Handle, flags uint8) (err error) = SetFileCompletionNotificationModes +// --- copied from https://golang.org/src/internal/poll/fd_windows.go --- +// This package uses the SetFileCompletionNotificationModes Windows +// API to skip calling GetQueuedCompletionStatus if an IO operation +// completes synchronously. There is a known bug where +// SetFileCompletionNotificationModes crashes on some systems (see +// https://support.microsoft.com/kb/2568167 for details). + +var useSetFileCompletionNotificationModes bool // determines is SetFileCompletionNotificationModes is present and safe to use + +// checkSetFileCompletionNotificationModes verifies that +// SetFileCompletionNotificationModes Windows API is present +// on the system and is safe to use. +// See https://support.microsoft.com/kb/2568167 for details. +func checkSetFileCompletionNotificationModes() { + err := syscall.LoadSetFileCompletionNotificationModes() + if err != nil { + return + } + protos := [2]int32{syscall.IPPROTO_TCP, 0} + var buf [32]syscall.WSAProtocolInfo + len := uint32(unsafe.Sizeof(buf)) + n, err := syscall.WSAEnumProtocols(&protos[0], &buf[0], &len) + if err != nil { + return + } + for i := int32(0); i < n; i++ { + if buf[i].ServiceFlags1&syscall.XP1_IFS_HANDLES == 0 { + return + } + } + useSetFileCompletionNotificationModes = true +} + +func initFileCompletionNotificationModes() { + var d syscall.WSAData + syscall.WSAStartup(uint32(0x202), &d) + + checkSetFileCompletionNotificationModes() +} + +// END --- copied from https://golang.org/src/internal/poll/fd_windows.go --- + type atomicBool int32 func (b *atomicBool) isSet() bool { return atomic.LoadInt32((*int32)(b)) != 0 } @@ -64,6 +107,7 @@ type ioOperation struct { } func initIo() { + initFileCompletionNotificationModes() h, err := createIoCompletionPort(syscall.InvalidHandle, 0, 0, 0xffffffff) if err != nil { panic(err) @@ -99,9 +143,11 @@ func makeWin32File(h syscall.Handle) (*win32File, error) { if err != nil { return nil, err } - err = setFileCompletionNotificationModes(h, cFILE_SKIP_COMPLETION_PORT_ON_SUCCESS|cFILE_SKIP_SET_EVENT_ON_HANDLE) - if err != nil { - return nil, err + if useSetFileCompletionNotificationModes { + err = setFileCompletionNotificationModes(h, cFILE_SKIP_COMPLETION_PORT_ON_SUCCESS|cFILE_SKIP_SET_EVENT_ON_HANDLE) + if err != nil { + return nil, err + } } f.readDeadline.channel = make(timeoutChan) f.writeDeadline.channel = make(timeoutChan)