github.com/Microsoft/go-winio/pkg/guid v0.4.14 does not build on linux

[fejta]

$ go build github.com/Microsoft/go-winio/pkg/guid
../../../go/pkg/mod/github.com/!microsoft/[email protected]/pkg/guid/guid.go:16:2: build constraints exclude all Go files in /usr/local/google/home/fejta/go/pkg/mod/golang.org/x/[email protected]/windows

Can we flag packages that we only expect to build on linux? AKA add a // +build windows line etc

$ grep -R "+build" ~/go/pkg/mod/golang.org/x/[email protected]/windows/*
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/[email protected]/windows/aliases.go:// +build windows
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/[email protected]/windows/aliases.go:// +build go1.9
/usr/local/google/home/fejta/go/pkg/mod/golang.org/x/[email protected]/windows/eventlog.go:// +build windows

[jterry75]

@kevpar - PTAL

[networkimprov]

Please drop the x/sys/windows dependency.

See also golang/go#36485

[jterry75]

@kevpar - Can you take a look please?

[dtbartle]

Looks like #169 is ready to be merged? Anything blocking that?

[narph]

any updates here? it all seems to be good to go in #169