SearchBox: Fixed bug when autoFocus set to true #6566
Merged
+12
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run change
Description of changes
If
autoFocus={true}
for the SearchBox component,onFocusCapture
for the root div (here) is called before the ref is set tothis._rootElement
on the same line.This results in
this._rootElement.current
being null inthis._onFocusCapture
. This seems to be an issue with React, shown here, and I got the workaround from the very same issue.Microsoft Reviewers: Open in CodeFlow