Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContextualMenu: Default not prevented after handling keydown #835

Closed
T-Hugs opened this issue Jan 18, 2017 · 3 comments
Closed

ContextualMenu: Default not prevented after handling keydown #835

T-Hugs opened this issue Jan 18, 2017 · 3 comments
Assignees

Comments

@T-Hugs
Copy link
Contributor

T-Hugs commented Jan 18, 2017

Bug Report

  • Package version(s): (fill this out)
  • Browser and OS versions: All

Describe the issue:

ContextualMenu: Default not prevented after handling keydown

Actual behavior:

Expected behavior:

Default is prevented so the parent doesn't decide to handle the event.

If applicable, please provide a codepen repro:

@T-Hugs T-Hugs changed the title [Patch] ContextualMenu: Default not prevented after handling keydown ContextualMenu: Default not prevented after handling keydown Jan 18, 2017
@T-Hugs
Copy link
Contributor Author

T-Hugs commented Jan 18, 2017

I was going to submit a pull request, but I don't have time to complete the entire checklist. In ContextualMenu.tsx, the line ev.preventDefault(); should be included in the _onItemKeyDown method, inside the if-statement.

@dzearing
Copy link
Member

@trevorsg if you could submit a PR, we can take a look and help with the missing checkboxes. @joschect FYI

@dzearing
Copy link
Member

Merged, published tomorrow.

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants