Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Input Improvements: Meta Issue #7636

Closed
micahgodbolt opened this issue Jan 14, 2019 · 2 comments
Closed

Form Input Improvements: Meta Issue #7636

micahgodbolt opened this issue Jan 14, 2019 · 2 comments
Assignees
Labels
Needs: Backlog review Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic
Milestone

Comments

@micahgodbolt
Copy link
Member

micahgodbolt commented Jan 14, 2019

Up until now our form inputs have been pretty purpose built for how they get used in our primary applications. We have not been spending much time thinking about how form inputs work as a whole. Consistent required states, labels, descriptions and error text. Controlled vs uncontrolled. An easy way to combine inputs into a single form and get a response on submit.

This issue is to capture all of the various input coherence efforts in our backlog and ensure that we have a well thought out plan for what our inputs look like in the future.

New Controls/Refactors

New Component: TextField Refactor #6827
New Component: Form #5582
ComboBox/Dropdown: refactor and/or merge #6030
Investigate using ContextualMenu for the menus in the dropdown and comboBox components #5206
Feature: Unified Error and validation handling for "Form" components #3620
DatePicker: onRenderPrefix, onRenderSuffix #5290 (This should come via TextField, or an abstraction of Textifield view, being the base control for all pickers)

Misc

BasePicker: add description and errorMessage props #7457
Pickers should have isRequired property #6636
add underline style for DatePicker and Dropdown #5631
Add errorMessage to ChoiceGroup Component #6527
Indeterminate state missing for Radio and Checkbox #5390
Dropdown: Add public interface to get selected value #7692 (this applies to all form components)
SpinButton: Add errorMessage and onGetErrorMessage #11923

@ThreadPitt
Copy link

Yes, that is something that makes it quite hard for us devs to work with it, e.g. I'd expect to be an "errorMessage" on all components, etc. Especially, if you use something like yup to roll your validation logic and you have no consistent way to set an error message across all controls.

Nonetheless, keep up to good work, guys!

@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 26, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Backlog review Resolution: Soft Close Soft closing inactive issues over a certain period Type: Epic
Projects
None yet
Development

No branches or pull requests

6 participants