Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/Feature: Datepicker - Callout dismisses when user picks a date #20638

Closed
eivindland opened this issue Nov 17, 2021 · 4 comments
Closed

Bug/Feature: Datepicker - Callout dismisses when user picks a date #20638

eivindland opened this issue Nov 17, 2021 · 4 comments
Assignees
@spmonahan
Labels
Component: DatePicker Needs: Attention

Comments

@eivindland
Copy link

Similar issue

There is a related issue already registered on Callout component. The pull request suggested would solve this Datepicker issue as well:
#19797

Environment Information

  • Package version(s): @fluentui/react: 8.29.1
"react": "17.0.2"
  • Browser and OS versions: Not relevant - fails similarly in all major browsers

Please provide a reproduction of the bug in a codepen:

Reproduction of the issue:
 https://codesandbox.io/s/fluentui-datepicker-9rlyo


  • Render Datepicker from a shadow-dom (ie. web-component)
  • Pick a date
  • The Callout dismisses and the Datepicker closes without picking a date

The bug is in Callout, in dismissOnClickOrScroll which ev.target. It should read event's composedPath.

Expected behavior:

dismissOnClickOrScroll gets its target from ev.composedPath and properly calculates isEventTargetOutsideCallout.

Priorities and help requested:

Are you willing to submit a PR to fix?

This PR fixes the bug: #19798

Requested priority: Blocking -> We are unable to use Datepicker within our solution for now
@gouttierre
Copy link
Contributor

@eivindland - thank you for filing this issue and apologies on the delay in reviewing the PR (#19798) associated to this issue.

@spmonahan / @GeoffCoxMSFT - Could you please help out here?

@gouttierre gouttierre added Component: DatePicker Needs: Investigation The Shield Dev should investigate this issue and propose a fix and removed Needs: Triage 🔍 labels Jan 5, 2022
@gouttierre gouttierre moved this to Good Issues (High Priority) in Fluent UI - Shield Priors Jan 10, 2022
@spmonahan spmonahan assigned spmonahan and unassigned spmonahan Jan 14, 2022
@spmonahan spmonahan mentioned this issue Jan 15, 2022
Merged
2 tasks
@spmonahan
Copy link
Contributor

@eivindland can you confirm this is fixed in 8.50.0?

@spmonahan spmonahan added Needs: Author Feedback and removed Needs: Investigation The Shield Dev should investigate this issue and propose a fix labels Jan 21, 2022
@spmonahan spmonahan self-assigned this Jan 21, 2022
@eivindland
Copy link
Author

Yes, I can confirm that this issue is fixed. Thanks!

@TristanWatanabe
Copy link
Member

Fixed by #19798

Repository owner moved this from Good Issues (High Priority) to Done in Fluent UI - Shield Priors Feb 4, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@spmonahan spmonahan

Labels
Component: DatePicker Needs: Attention
Projects
Fluent UI - Shield Priors
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@khmakoto @TristanWatanabe @eivindland @msft-fluent-ui-bot @gouttierre @spmonahan