Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-slider uses enzyme for parts of its testing #20246

Closed
khmakoto opened this issue Oct 18, 2021 · 0 comments · Fixed by #20657
Closed

react-slider uses enzyme for parts of its testing #20246

khmakoto opened this issue Oct 18, 2021 · 0 comments · Fixed by #20657
Assignees
@micahgodbolt
Labels
Area: Testing Component: Slider Priority 3: Low Status: Fixed Fixed in some PR

Comments

@khmakoto
Copy link
Member

The @fluentui/react-slider package has a mixture of enzyme and @testing-library/react usage for its testing. Since we are consolidating on using @testing-library/react for testing in vNext we should remove the use of enzyme.

Files that use enzyme:
@khmakoto khmakoto self-assigned this Oct 18, 2021
@khmakoto khmakoto mentioned this issue Oct 18, 2021
Closed
26 tasks
@behowell behowell assigned micahgodbolt and unassigned khmakoto Nov 11, 2021
@khmakoto khmakoto mentioned this issue Dec 14, 2021
Merged
6 tasks
Repository owner moved this from Todo to Done in @fluentui/react-components v9.0.0 Jan 5, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added the Status: Fixed Fixed in some PR label Jan 5, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@micahgodbolt micahgodbolt

Labels
Area: Testing Component: Slider Priority 3: Low Status: Fixed Fixed in some PR
Projects
@fluentui/react-components v9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slider refactor micahgodbolt/fluentui
4 participants
@micahgodbolt @khmakoto @miroslavstastny @msft-fluent-ui-bot