Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project: Finish Input implementation #20159

Closed
10 of 13 tasks
ecraig12345 opened this issue Oct 7, 2021 · 3 comments
Closed
10 of 13 tasks

Project: Finish Input implementation #20159

ecraig12345 opened this issue Oct 7, 2021 · 3 comments

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Oct 7, 2021

Problem

Input (text input), Checkbox, Switch, and Slider have been written to varying degrees but are not yet included in the v9 beta.

Part of #18131

Appetite

November

Solution

Other input components are tracked by separate issues:

Risks (Rabbit holes)

RangedSlider may require additional work (compared to the other listed components) to get ready for beta. It can probably be cut from the scope if needed unless there's immediate demand from a partner.

Other risks TBD

Out of scope (No-gos)

Aside from the specific Input features listed above, this project does NOT include implementing additional features in any of the components.

Related components/patterns that are in progress in November but NOT covered in this proposal and probably not expected to be ready for beta by end of month:

  • Field
  • Radio
  • Dropdown
@ecraig12345
Copy link
Member Author

End of October retrospective

What was achieved?

  • The spec and related implementation changes for Input should be checked in by EOM (almost ready now)
  • Decided to remove bookends from initial Input implementation
  • (This really belongs in a separate project, but we figured out some key points of the Field spec that influence multiple input components.)

What did we miss?

Everything else. There were a lot of build fires this month, plus a good bit of time was spent on discussions and experiments related to the Field spec (and there was FHL).

What went well?

  • Deciding to remove bookends from the core Input was a good idea
  • With discussions throughout the month, we have more clarity about the direction of input components moving forward

What could have gone better?

  • Make an explicit project for the Field work
  • Figure out a process to reduce randomization from build issues ("build shield")

What changed from initial expectations?

see above

@behowell
Copy link
Contributor

@ecraig12345 I've split this into separate issues for each component, and scoped this issue to track only the input work. This way each issue has a single owner and tracks a single component.

@behowell behowell assigned ecraig12345 and unassigned khmakoto Nov 12, 2021
@behowell behowell changed the title Project: ship existing input components to beta Project: Finish Input implementation Nov 12, 2021
@ecraig12345
Copy link
Member Author

What was achieved?

  • Add interaction styling
  • Change fieldSize prop name back to size (so we have the same prop name across components)
  • Add screener tests
  • PR for primary slot and onChange

What did we miss?

  • Merging PR for primary slot and onChange
  • Add stories

What went well?

  • The styles are finally updated!
  • We decided on a consistent name for "visual size" prop across components

What could have gone better?

  • Didn't get as much done due to non-work obligations, getting sick, and build fires
  • Some rabbit holes of making fixes to vr-tests infrastructure

What changed from initial expectations?

  • Non-work obligations this month took longer than expected, taking away from this project

Repository owner moved this from Todo to Done in @fluentui/react-components v9.0.0 Dec 6, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

4 participants