Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-button uses enzyme for parts of its testing #19941

Closed
khmakoto opened this issue Sep 23, 2021 · 1 comment · Fixed by #20342
Closed

react-button uses enzyme for parts of its testing #19941

khmakoto opened this issue Sep 23, 2021 · 1 comment · Fixed by #20342
Assignees
@khmakoto
Labels
Area: Testing Component: Button Priority 1: High Status: Fixed Fixed in some PR

Comments

@khmakoto
Copy link
Member

khmakoto commented Sep 23, 2021 •
edited
Loading

The @fluentui/react-button package uses enzyme for parts of its testing. Since we are consolidating on using @testing-library/react and/or react-test-renderer for testing in vNext we should remove the use of enzyme.

Files that use enzyme:
@khmakoto khmakoto self-assigned this Sep 23, 2021
@khmakoto khmakoto closed this as completed Oct 4, 2021
@khmakoto khmakoto reopened this Oct 18, 2021
@khmakoto khmakoto mentioned this issue Oct 18, 2021
Closed
26 tasks
@khmakoto khmakoto changed the title Convert react-button to use @testing-library/react react-button uses enzyme and react-test-renderer for its testing Oct 18, 2021
@khmakoto
Copy link
Member Author

We've determined the use of react-test-renderer should be allowed.

@khmakoto khmakoto changed the title react-button uses enzyme and react-test-renderer for its testing react-button uses enzyme for part of its testing Oct 20, 2021
@khmakoto khmakoto changed the title react-button uses enzyme for part of its testing react-button uses enzyme for parts of its testing Oct 20, 2021
@khmakoto khmakoto mentioned this issue Oct 26, 2021
Merged
2 tasks
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Nov 1, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@khmakoto khmakoto

Labels
Area: Testing Component: Button Priority 1: High Status: Fixed Fixed in some PR
Projects
@fluentui/react-components v9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing use of enzyme in react-button and improving Button and Link tests khmakoto/fluentui
3 participants
@khmakoto @miroslavstastny @msft-fluent-ui-bot