Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Select Dropdown : On reset form or changing to initial values , NVDA/Narrator is reading the place holder text in multi select dropdown. #19513

Closed
vaishnavi-115 opened this issue Aug 25, 2021 · 5 comments · Fixed by #19667
Assignees
Labels
Area: Accessibility Area: Narrator Area: NVDA NVDA screen reader Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Chrome Status: Fixed Fixed in some PR

Comments

@vaishnavi-115
Copy link

Environment Information
Package version(s): "@fluentui/react": "^7.126.0",
Browser and OS versions: Chrome , windows 10
Please provide a reproduction of the bug in a codepen:
Actual behavior:
On reset form or clearing the values to initial values on button click, NVDA/Narrator is reading the place holder text in multi select dropdown.

Expected behavior:
On reset form or clearing the values to initial values on button click, NVDA/Narrator should not read the place holder text in multi select dropdown.

@vaishnavi-115
Copy link
Author

Please find the sandbox link to repro the issue.
https://codesandbox.io/s/unruffled-jones-sqeeq?file=/src/MultiSelectExample.js

@gouttierre gouttierre added Area: Narrator Area: NVDA NVDA screen reader Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix OS: Windows 10 Platform: Chrome Area: Accessibility and removed Needs: Triage 🔍 labels Sep 7, 2021
@gouttierre
Copy link
Contributor

@vaishnavi-115 - Thanks for filing this issue with us and updating it with the codepen. To set expectation our team will have a look at the issue but only once capacity allows.

@bsunderhus - Would you be able to confirm if this is a regression, or if this behavior is an issue?
cc @smhigley

@smhigley
Copy link
Contributor

smhigley commented Sep 7, 2021

Looks like it's because we have aria-live="off", which is ironically not supported, and defaulting to assertive. If we remove the live region attribute entirely, it doesn't read out.

@smhigley
Copy link
Contributor

smhigley commented Sep 7, 2021

I've added a PR fixing this in v8, though it's worth noting the codepen is in v6, which has different live region attributes and would need a different PR (probably not just a cherry-pick).

@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #19667, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Accessibility Area: Narrator Area: NVDA NVDA screen reader Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Platform: Chrome Status: Fixed Fixed in some PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants