From e766283fefc21847efe3f643c8bd66f2d18ff657 Mon Sep 17 00:00:00 2001
From: jeff smith <jes@microsoft.com>
Date: Wed, 24 Jul 2024 21:15:40 -0700
Subject: [PATCH] addressed feedback
---
packages/web-components/docs/api-report.md | 4 +-
.../src/accordion-item/accordion-item.ts | 38 +++++++++----------
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/packages/web-components/docs/api-report.md b/packages/web-components/docs/api-report.md
index 96e1a96cefcbc4..3bfb9de0df9953 100644
--- a/packages/web-components/docs/api-report.md
+++ b/packages/web-components/docs/api-report.md
@@ -53,6 +53,8 @@ export type AccordionExpandMode = ValuesOf<typeof AccordionExpandMode>;
//
// @public
export class AccordionItem extends BaseAccordionItem {
+ block: boolean;
+ blockChanged(prev: boolean, next: boolean): void;
markerPosition?: AccordionItemMarkerPosition;
markerPositionChanged(prev: AccordionItemMarkerPosition, next: AccordionItemMarkerPosition): void;
size?: AccordionItemSize;
@@ -426,8 +428,6 @@ export const BadgeTemplate: ElementViewTemplate<Badge>;
// @public (undocumented)
export class BaseAccordionItem extends FASTElement {
- block: boolean;
- blockChanged(prev: boolean, next: boolean): void;
disabled: boolean;
disabledChanged(prev: boolean, next: boolean): void;
// @internal
diff --git a/packages/web-components/src/accordion-item/accordion-item.ts b/packages/web-components/src/accordion-item/accordion-item.ts
index 8c390114e4232d..1bdcaefad2fe76 100644
--- a/packages/web-components/src/accordion-item/accordion-item.ts
+++ b/packages/web-components/src/accordion-item/accordion-item.ts
@@ -100,25 +100,6 @@ export class BaseAccordionItem extends FASTElement {
@attr
public id: string = uniqueId('accordion-');
- /**
- * Sets the width of the focus state.
- *
- * @public
- * @remarks
- * HTML Attribute: block
- */
- @attr({ mode: 'boolean' })
- public block: boolean = false;
-
- /**
- * Handles changes to block attribute
- * @param prev - previous value
- * @param next - next value
- */
- public blockChanged(prev: boolean, next: boolean): void {
- toggleState(this.elementInternals, 'block', next);
- }
-
/**
* @internal
*/
@@ -179,6 +160,25 @@ export class AccordionItem extends BaseAccordionItem {
toggleState(this.elementInternals, `align-${next}`, true);
}
}
+
+ /**
+ * Sets the width of the focus state.
+ *
+ * @public
+ * @remarks
+ * HTML Attribute: block
+ */
+ @attr({ mode: 'boolean' })
+ public block: boolean = false;
+
+ /**
+ * Handles changes to block attribute
+ * @param prev - previous value
+ * @param next - next value
+ */
+ public blockChanged(prev: boolean, next: boolean): void {
+ toggleState(this.elementInternals, 'block', next);
+ }
}
/**