-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column breakpoints in fast-layouts uses the default breakpoints to determine start/span values #2602
Comments
@shauntc would you like to send a PR for this? |
@chrisdholt I can do a PR for this but it'll be a few days before I get to it |
That works for us - if we get additional feedback that this is higher impact from other folks we can jump on it; though, considering you filed the issue I'll trust your priority on it :). Thanks! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
closed with #3517 |
The fast layouts column uses the default breakpoints instead of ones set in the fast breakpoint tracker to determine what span/start value to use (though the check is triggered by the fast breakpoint tracker breakpoints).
This happens because this line uses this utility function without a second parameter, causing it to use the default value (which is the default breakpoints). The easiest solution would be to just add passing in the breakpoints here but I would suggest also removing the default value here or moving things around so that
defaultBreakpoints
are never exposed (and are only used by the fast breakpoint tracker)What are the steps to reproduce the issue?
defaultBreakpoints
values to select which span/start value to useThe text was updated successfully, but these errors were encountered: