-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Focus-visible support breaking in newer versions of the polyfill #2591
Comments
Thanks for the issue @Pogodaanton - I think there's an issue of being between implementations for this to get fixed. I do think we'll want to be on the latest version, but that will require a dependency change that would impact folks already on v4 of the polyfill. One quick fix is to document that we require ^v4. Alternatively, we could make the change in the dependency and update our code - but that would potentially break folks with a lower version. @nicholasrice for thoughts as well. |
I think it would be relatively trivial to select for both html and body for the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
closed with #3517 |
Versions following the implementation of a Shadow-DOM tracker don't work with FAST's focus-visible JSS, as the
js-focus-visible
class is now placed into the<html/>
tag rather than the<body/>
tag.What are the steps to reproduce the issue?
@microsoft/fast-components-react-msft^4.28.4
andfocus-visible^5.0.2
:focus
stylingWhat behavior did you expect?
Selected component does not appear to be in focus while using a mouse.
Temporary solution
Downgrading to an older version of the said package:
focus-visible^4.1.5
The text was updated successfully, but these errors were encountered: