Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading spinner to auto-suggest component #2552

Closed
fmamic opened this issue Jan 6, 2020 · 5 comments
Closed

Add loading spinner to auto-suggest component #2552

fmamic opened this issue Jan 6, 2020 · 5 comments

Comments

@fmamic
Copy link
Contributor

fmamic commented Jan 6, 2020

What feature are you requesting?

Loading spinner is missing from the auto-suggest component so custom spinner needs to be added when loading data async.

What would be the benefit of adding this feature?
No need for custom implementation of the loading spinner in the auto-suggest component.

What solution would be ideal for you?
Auto-suggest component with the small spinner on the right side and controlled with the component props (can be turned on/off)

What alternatives have you considered?
Custom component: adding auto-suggest component plus the spinner above it.

Is there any additional context for your request?
Component in question: https://explore.fast.design/components/auto-suggest

Attach screenshots or images add detail to your request:
1

@triage-new-issues triage-new-issues bot added the status:triage New Issue - needs triage label Jan 6, 2020
@fmamic fmamic changed the title Add loading spinner to auto-suggest component feat: Add loading spinner to auto-suggest component Jan 6, 2020
@scomea
Copy link
Collaborator

scomea commented Jan 6, 2020

Currently this can be achieved with a custom input region render function.

As the component itself has no notion of loading states I’d suggest this would be an enhancement to the MSFT styled version and not base if we decided to add it.

I think it makes sense to add it for the sake of design consistency if we see this as a common thing for devs to add. We'd probably want to think about how we handle loading states across the framework along with this - visuals, accessibility, etc...

@chrisdholt
Copy link
Member

@fmamic does this help solve the issue? I think this is likely somewhat related to #2255 although slightly different.

@chrisdholt chrisdholt changed the title feat: Add loading spinner to auto-suggest component Add loading spinner to auto-suggest component Jan 9, 2020
@chrisdholt chrisdholt added the status:needs-information This issue needs more information label Jan 9, 2020
@triage-new-issues triage-new-issues bot removed the status:triage New Issue - needs triage label Jan 9, 2020
@stale
Copy link

stale bot commented Apr 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Apr 8, 2020
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@EisenbergEffect EisenbergEffect added area:react and removed reason : stale status:needs-information This issue needs more information warning:stale No recent activity within a reasonable amount of time labels Jul 20, 2020
@chrisdholt
Copy link
Member

closed with #3517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants