Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update button component to align with latest component expectations in base #249

Closed
chrisdholt opened this issue Apr 12, 2018 · 1 comment
Assignees
Labels
feature A new feature

Comments

@chrisdholt
Copy link
Member

Expected behavior

Button should include the necessary rails at the base component level.

Actual behavior

Button currently exposes either a button or anchor HTML element which aligns to an older principle of base components only exposing the base element functionality. It needs to be updated to align with our current philosophy of adding general rails that include some base styling options to allow full customization.

Steps to reproduce the problem

Specifications (hardware, software, configurations)

  • Include device make, model, OS version:
  • Include browser and version:
  • Include screen orientation:
  • Include screen size:
  • Include page URL:
  • Include localization:

Please attach screenshots or video of the problem for quickest resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

3 participants