Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tests to select for internal state when options change #2278

Closed
scomea opened this issue Sep 30, 2019 · 2 comments
Closed

chore: add tests to select for internal state when options change #2278

scomea opened this issue Sep 30, 2019 · 2 comments
Assignees

Comments

@scomea
Copy link
Collaborator

scomea commented Sep 30, 2019

Test to see if state will fall out of sync when props are updated, such as adding/removing children.

ex. The select is instantiated with no items as children and is disabled, the user makes a change somewhere else in the UI which prompts a backend service to fetch data and items are populated in the select.

@scomea scomea self-assigned this Sep 30, 2019
@triage-new-issues triage-new-issues bot added the status:triage New Issue - needs triage label Sep 30, 2019
@nicholasrice nicholasrice added the feature A new feature label Oct 1, 2019
@triage-new-issues triage-new-issues bot removed the status:triage New Issue - needs triage label Oct 1, 2019
@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@chrisdholt
Copy link
Member

closed with #3517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants