Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash get from class names in the tooling components #2171

Closed
janechu opened this issue Aug 22, 2019 · 4 comments
Closed

Remove lodash get from class names in the tooling components #2171

janechu opened this issue Aug 22, 2019 · 4 comments

Comments

@janechu
Copy link
Collaborator

janechu commented Aug 22, 2019

Convert the managed classes in the tooling components to use the classNames utilities that the @microsoft/fast-components-base-react uses so that there is not so much over-use of the lodash get utility.

classNames can be imported as a secondary import from the @microsoft/fast-web-utilities package.

This should improve perf of the tooling.

@janechu janechu added feature A new feature community:good-first-issue Good issues for first time contributors labels Aug 22, 2019
@nicholasrice
Copy link
Contributor

managedClasses should be added to the defaultProps object:

public static defaultProps = { managedClasses: {}}

@janechu
Copy link
Collaborator Author

janechu commented Oct 17, 2019

This has been done on the Form component with #2280, still needed for the Navigation and NavigationMenu.

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the reason : stale label Jul 18, 2020
@EisenbergEffect EisenbergEffect added area:react and removed reason : stale community:good-first-issue Good issues for first time contributors feature A new feature labels Jul 20, 2020
@chrisdholt
Copy link
Member

closed by #3517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants