Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref-forwarding to all Base and MSFT components #1668

Closed
nicholasrice opened this issue Apr 16, 2019 · 7 comments
Closed

Add ref-forwarding to all Base and MSFT components #1668

nicholasrice opened this issue Apr 16, 2019 · 7 comments

Comments

@nicholasrice
Copy link
Contributor

It looks like React is deprecating ReactDOM.findDOMNode: https://reactjs.org/docs/react-dom.html#finddomnode

Our current reccomended to retrieve a DOM node is through that method, so I think we need to integrate ref forwarding into all of our components. While this should be pretty transparent for many components, there are several components that provide public properties on class instances, which we will need to provide alternate solutions for.

@nicholasrice nicholasrice added chore Maintenance or non-code work breaking change 💥 labels Apr 16, 2019
@shauntc
Copy link
Contributor

shauntc commented Jun 5, 2019

+1

@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Sep 3, 2019
@nicholasrice
Copy link
Contributor Author

We could implement the innerRef model, where ref applies a ref to the component instance and innerRef applies a ref to the root DOM node.

@stale stale bot removed the warning:stale No recent activity within a reasonable amount of time label Sep 12, 2019
@stale
Copy link

stale bot commented Dec 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Dec 11, 2019
@chrisdholt
Copy link
Member

I believe this is slated for our next major version, not stale

@stale stale bot removed the warning:stale No recent activity within a reasonable amount of time label Dec 16, 2019
@stale
Copy link

stale bot commented Mar 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Mar 15, 2020
@EisenbergEffect EisenbergEffect added area:react and removed breaking change 💥 chore Maintenance or non-code work warning:stale No recent activity within a reasonable amount of time labels Jul 17, 2020
@chrisdholt
Copy link
Member

closed by #3517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants