Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit React components to ensure they work well in <StrictMode> #1045

Closed
chrisdholt opened this issue Oct 17, 2018 · 1 comment
Closed

Audit React components to ensure they work well in <StrictMode> #1045

chrisdholt opened this issue Oct 17, 2018 · 1 comment
Milestone
January 2019

Comments

@chrisdholt
Copy link
Member

What is strict mode?
StrictMode is a tool for highlighting potential problems in an application. Like Fragment, StrictMode does not render any visible UI. It activates additional checks and warnings for its descendants.

More from ReactJS on StrictMode: https://reactjs.org/docs/strict-mode.html

It seems probably that development teams would want to run their applications in strict mode on dev to ensure that potential problems are caught. We should audit our components and packages that leverage react to find any potential issues from running in strict mode.

For anything small, we can immediate fix. Anything potentially breaking or large-scale should result in a new task.
@chrisdholt chrisdholt added the feature A new feature label Oct 17, 2018
@chrisdholt chrisdholt self-assigned this Oct 17, 2018
@Falkicon Falkicon added this to the January 2019 milestone Jan 13, 2019
@chrisdholt chrisdholt removed their assignment Apr 4, 2019
@chrisdholt
Copy link
Member Author

closed by #3517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2019
Development

No branches or pull requests
3 participants
@EisenbergEffect @Falkicon @chrisdholt