Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions are not being logged #378

Closed
dkbennett opened this issue Apr 10, 2024 · 0 comments · Fixed by #379
Closed

Exceptions are not being logged #378

dkbennett opened this issue Apr 10, 2024 · 0 comments · Fixed by #379
Assignees
@dkbennett
Labels
Area-Core Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release
Milestone
DHGE v0.13

Comments

@dkbennett
Copy link
Member

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Exceptions are not being logged due to incorrect ordering in the log message.

Error(ex, "Message") is correct format, while current logs are Error("Message", ex).

Expected result

No response

Actual result

Exceptions not being logged.

Included System Information

No response
@dkbennett dkbennett added the Issue-Bug Something isn't working or needs investigation label Apr 10, 2024
@dkbennett dkbennett self-assigned this Apr 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Apr 10, 2024
@dkbennett dkbennett mentioned this issue Apr 10, 2024
Merged
3 tasks
@krschau krschau added Priority-2 Area-Core and removed Needs-Triage New issue that the core contributors need to triage labels Apr 10, 2024
@krschau krschau added this to the DHGE v0.13 milestone Apr 10, 2024
@krschau krschau added the Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkbennett dkbennett

Labels
Area-Core Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release
Projects
None yet
Milestone
DHGE v0.13
Development

Successfully merging a pull request may close this issue.

Fix exception logging microsoft/devhomegithubextension
2 participants
@dkbennett @krschau