Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning a repo does not clone submodules #1619

Closed
asklar opened this issue Sep 29, 2023 · 3 comments · Fixed by microsoft/devhomegithubextension#384
Closed

Cloning a repo does not clone submodules #1619

asklar opened this issue Sep 29, 2023 · 3 comments · Fixed by microsoft/devhomegithubextension#384
Assignees
@dhoehna
Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Repo Related to Repo setup, cloning, etc Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release
Milestone
Dev Home v0.14

Comments

@asklar
Copy link
Member

asklar commented Sep 29, 2023

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

See https://twitter.com/James_M_South/status/1707623052207665308
image

Submodules seem supported by libgit2sharp; LFS seems implementable via libgit2/libgit2sharp#1236

Expected result

No response

Actual result

submodules/LFS not cloned

Included System Information

No response

Included Extensions Information

No response
@asklar asklar added the Issue-Bug Something isn't working or needs investigation label Sep 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Sep 29, 2023
@krschau krschau added the Area-Machine-Config Related to the machine configuration feature label Oct 2, 2023
@kanismohammed kanismohammed added Priority-2 Area-Machine-Config-Repo Related to Repo setup, cloning, etc and removed Needs-Triage New issue that the core contributors need to triage labels Nov 1, 2023
@dhoehna dhoehna self-assigned this Apr 15, 2024
@dhoehna dhoehna mentioned this issue Apr 24, 2024
Merged
3 tasks
@dhoehna
Copy link
Contributor

dhoehna commented Apr 24, 2024

microsoft/devhomegithubextension#384 allows the GitHub extension to clone submodules. LFS is still incomplete and needs more dev work. The GitHub extension has a feature-request to add LFS support.

@krschau krschau added this to the Dev Home v0.14 milestone Apr 24, 2024
@krschau
Copy link
Collaborator

krschau commented Apr 26, 2024

Editing name to reflect that LFS is tracked separately.

@krschau krschau changed the title Cloning a repo does not clone submodules or LFS Cloning a repo does not clone submodules Apr 26, 2024
@dhoehna
Copy link
Contributor

dhoehna commented Apr 26, 2024

PR is in the extension.

@dhoehna dhoehna closed this as completed Apr 26, 2024
@krschau krschau linked a pull request Apr 29, 2024 that will close this issue
Cloning submodules microsoft/devhomegithubextension#384
Merged
3 tasks
@krschau krschau added the Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release label Apr 29, 2024
@krschau krschau added Resolution-Fix-Available Available in a release and removed Resolution-Fix-Committed Fix is checked in, but may take 3-4 weeks before it's in a release labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhoehna dhoehna

Labels
Area-Machine-Config Related to the machine configuration feature Area-Machine-Config-Repo Related to Repo setup, cloning, etc Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release
Projects
None yet
Milestone
Dev Home v0.14
Development

Successfully merging a pull request may close this issue.

Cloning submodules microsoft/devhomegithubextension
4 participants
@dhoehna @asklar @krschau @kanismohammed