Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling extension doesn't turn off functionality #1390

Closed
crutkas opened this issue Aug 10, 2023 · 6 comments
Closed

Disabling extension doesn't turn off functionality #1390

crutkas opened this issue Aug 10, 2023 · 6 comments
Labels
Area-Extensibility Related to extensions Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release

Comments

@crutkas
Copy link
Member

crutkas commented Aug 10, 2023

Dev Home version

0.401.219.0

Windows build number

10.0.25926.1001

Other software

OS Build Version: 10.0.25926.1001.amd64fre.rs_we_adept.230805-1700
.NET Version: .NET 6.0.20

Steps to reproduce the bug

  1. disable extensions
  2. Go to dashboard
  3. go to "add widget"
  4. See disabled extensions

image
image

Expected result

Extensions do not show up

Actual result

Preview extensions show up while off

Included System Information

Physical Memory: 31.84GB (17.34GB free)
Processor Architecture: x64

Included Extensions Information

Extensions:
Microsoft.Windows.DevHome_0.301.198.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension_0.300.198.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHome.Canary_0.401.219.0_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension.Canary_0.400.219.0_x64__8wekyb3d8bbwe

@crutkas crutkas added the Issue-Bug Something isn't working or needs investigation label Aug 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage New issue that the core contributors need to triage label Aug 10, 2023
@crutkas crutkas changed the title Disabling extension doesn't turn off widget Disabling extension doesn't turn off functionality Aug 10, 2023
@crutkas
Copy link
Member Author

crutkas commented Aug 10, 2023

Clone repo shouldn't have a hook and still does even with fully disabled.
image
image

@krschau krschau added the Area-Extensibility Related to extensions label Aug 10, 2023
@embender
Copy link
Member

embender commented Aug 10, 2023

I am also seeing extensions appear within add widgets that are not within the extensions settings page, should I make this a separate issue? It feels related, I'm on the same version of Dev Home too

image
image

@crutkas
Copy link
Member Author

crutkas commented Aug 10, 2023

dev home widgets for that version (canary vs preview), won’t appear intentionally. Canary won’t show canary’s core widgets. Is that what you are referring to?

@embender
Copy link
Member

not sure i understand what you're saying, I am saying that I see two options for extensions to turn off and then three different extensions within the "add widgets" area, with the discrepancy being with the Core (Preview) being an extension that appears within the add widgets, but not within the extension settings

@crutkas
Copy link
Member Author

crutkas commented Aug 11, 2023

Good catch but No one except us would see this difference between canary and preview naming quirk here. Also it would be a different bug.

@mathewleeza mathewleeza added Priority-2 and removed Needs-Triage New issue that the core contributors need to triage labels Nov 4, 2023
@mathewleeza mathewleeza added this to the Backlog milestone Nov 6, 2023
@krschau krschau removed this from the Backlog milestone Mar 19, 2024
@cinnamon-msft
Copy link
Contributor

Fixed in #3253

@cinnamon-msft cinnamon-msft added the Resolution-Fix-Available Available in a release label Aug 20, 2024
@krschau krschau added this to the Dev Home v0.16 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Extensibility Related to extensions Issue-Bug Something isn't working or needs investigation Priority-2 Resolution-Fix-Available Available in a release
Projects
None yet
Development

No branches or pull requests

5 participants