From f7fbe962371a0bc139b859c35144d1f8bb48f1de Mon Sep 17 00:00:00 2001 From: Tim Kurtzman <49733346+timkur@users.noreply.github.com> Date: Tue, 4 Jun 2024 17:21:57 -0700 Subject: [PATCH] Ironsides - Tooltips for the bar items (#3107) * Tooltips for the bar items * PR updates --- tools/PI/DevHome.PI/BarWindowHorizontal.xaml | 6 ++--- tools/PI/DevHome.PI/BarWindowVertical.xaml | 8 +++--- .../DevHome.PI/Strings/en-us/Resources.resw | 26 ++++++++++++------- .../ViewModels/BarWindowViewModel.cs | 5 ++++ 4 files changed, 30 insertions(+), 15 deletions(-) diff --git a/tools/PI/DevHome.PI/BarWindowHorizontal.xaml b/tools/PI/DevHome.PI/BarWindowHorizontal.xaml index 9215d0b1a3..48d8e62c71 100644 --- a/tools/PI/DevHome.PI/BarWindowHorizontal.xaml +++ b/tools/PI/DevHome.PI/BarWindowHorizontal.xaml @@ -33,7 +33,7 @@ - + - diff --git a/tools/PI/DevHome.PI/BarWindowVertical.xaml b/tools/PI/DevHome.PI/BarWindowVertical.xaml index 625f31b92d..611ced0822 100644 --- a/tools/PI/DevHome.PI/BarWindowVertical.xaml +++ b/tools/PI/DevHome.PI/BarWindowVertical.xaml @@ -29,14 +29,16 @@ - diff --git a/tools/PI/DevHome.PI/Strings/en-us/Resources.resw b/tools/PI/DevHome.PI/Strings/en-us/Resources.resw index 9b24e73d3a..df7d94e097 100644 --- a/tools/PI/DevHome.PI/Strings/en-us/Resources.resw +++ b/tools/PI/DevHome.PI/Strings/en-us/Resources.resw @@ -129,14 +129,6 @@ Restore Tooltip for the restore button in the BarWindow - - End PI service - The label for the close all menu item flyout. This will cause the program to terminate. - - - Close the PI window and the service - The tooltip for the close all menu item flyout. This will cause the program to terminate. - Pin A label for the menuitem to pin a tool on the bar. @@ -153,7 +145,7 @@ Dissociate so that PI is not tracking any app The tooltip for a button which causes PI to no longer track any app - + Expand or collapse the large content panel The tooltip for a button which expands or collapses the large content panel. @@ -905,4 +897,20 @@ Invalid tool path or name Text for the message to show to the user when the supplied path or name is not valid. + + Select a process to investigate + Describes using a button in PI's UX to investigate another process running on the system + + + Attach the diagnostic bar to the target application + Describes using a button in PI's UX + + + Dev Home PI + The product name + + + Close + Describes a button that will close PI's window + \ No newline at end of file diff --git a/tools/PI/DevHome.PI/ViewModels/BarWindowViewModel.cs b/tools/PI/DevHome.PI/ViewModels/BarWindowViewModel.cs index 8f0a24dfb8..fdeacc40b3 100644 --- a/tools/PI/DevHome.PI/ViewModels/BarWindowViewModel.cs +++ b/tools/PI/DevHome.PI/ViewModels/BarWindowViewModel.cs @@ -51,6 +51,9 @@ public partial class BarWindowViewModel : ObservableObject [ObservableProperty] private Visibility _appBarVisibility = Visibility.Visible; + [ObservableProperty] + private string _applicationName = string.Empty; + [ObservableProperty] private int _applicationPid; @@ -85,6 +88,7 @@ public BarWindowViewModel() if (process != null) { + ApplicationName = process.ProcessName; ApplicationPid = process.Id; ApplicationIcon = TargetAppData.Instance.Icon; } @@ -186,6 +190,7 @@ private void TargetApp_PropertyChanged(object? sender, PropertyChangedEventArgs if (process is not null) { ApplicationPid = process.Id; + ApplicationName = process.ProcessName; } }); }